Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for release CRs #290

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Add support for release CRs #290

wants to merge 9 commits into from

Conversation

njuettner
Copy link
Member

Towards: giantswarm/roadmap#3125

Aligning with CAPA/CAPZ Releases.

Since it's a breaking change I added a note to the changelog.

From now on we would fetch all app / helmrelease versions from the Release CR in releases repo for vsphere.

Trigger e2e tests

/run cluster-test-suites

@tinkerers-ci
Copy link

tinkerers-ci bot commented Sep 26, 2024

Note

As this is a draft PR no triggers from the PR body will be handled.

If you'd like to trigger them while draft please add them as a PR comment.

@github-actions GitHub Actions
Copy link
Contributor

There were differences in the rendered Helm template, please check! ⚠️

Output 
=== Differences when rendered with values file helm/cluster-vsphere/ci/test-wc-values.yaml ===

/metadata/labels  (v1/Secret/release-name-kubevip-pod)
  + one map entry added:
    release.giantswarm.io/version: 27.0.0

/metadata/labels  (v1/Secret/release-name-credentials)
  + one map entry added:
    release.giantswarm.io/version: 27.0.0

/metadata/labels  (v1/ConfigMap/org-giantswarm/test-cert-exporter-user-values)
  + one map entry added:
    release.giantswarm.io/version: 27.0.0

/metadata/labels  (v1/ConfigMap/org-giantswarm/test-cert-manager-user-values)
  + one map entry added:
    release.giantswarm.io/version: 27.0.0

/metadata/labels  (v1/ConfigMap/org-giantswarm/test-etcd-k8s-res-count-exporter-user-values)
  + one map entry added:
    release.giantswarm.io/version: 27.0.0

/metadata/labels  (v1/ConfigMap/org-giantswarm/test-metrics-server-user-values)
  + one map entry added:
    release.giantswarm.io/version: 27.0.0

/metadata/labels  (v1/ConfigMap/org-giantswarm/test-net-exporter-user-values)
  + one map entry added:
    release.giantswarm.io/version: 27.0.0

/metadata/labels  (v1/ConfigMap/org-giantswarm/test-node-exporter-user-values)
  + one map entry added:
    release.giantswarm.io/version: 27.0.0

/metadata/labels  (application.giantswarm.io/v1alpha1/App/org-giantswarm/test-capi-node-labeler)
  + one map entry added:
    release.giantswarm.io/version: 27.0.0

/spec/version  (application.giantswarm.io/v1alpha1/App/org-giantswarm/test-capi-node-labeler)
  ± value change
    - 0.5.0
    + N/A

/metadata/annotations  (application.giantswarm.io/v1alpha1/App/org-giantswarm/test-cert-exporter)
  - one map entry removed:
    # app-operator will make sure that the app on which it depends is installed before
    app-operator.giantswarm.io/depends-on: test-kyverno-crds
    
  

/metadata/labels  (application.giantswarm.io/v1alpha1/App/org-giantswarm/test-cert-exporter)
  + one map entry added:
    release.giantswarm.io/version: 27.0.0

/spec/version  (application.giantswarm.io/v1alpha1/App/org-giantswarm/test-cert-exporter)
  ± value change
    - 2.9.2
    + N/A

/metadata/annotations  (application.giantswarm.io/v1alpha1/App/org-giantswarm/test-cert-manager)
  - one map entry removed:
    # app-operator will make sure that the app on which it depends is installed before
    app-operator.giantswarm.io/depends-on: test-prometheus-operator-crd
    
  

/metadata/labels  (application.giantswarm.io/v1alpha1/App/org-giantswarm/test-cert-manager)
  + one map entry added:
    release.giantswarm.io/version: 27.0.0

/spec/version  (application.giantswarm.io/v1alpha1/App/org-giantswarm/test-cert-manager)
  ± value change
    - 3.8.1
    + N/A

/metadata/annotations  (application.giantswarm.io/v1alpha1/App/org-giantswarm/test-chart-operator-extensions)
  - one map entry removed:
    # app-operator will make sure that the app on which it depends is installed before
    app-operator.giantswarm.io/depends-on: test-prometheus-operator-crd
    
  

/metadata/labels  (application.giantswarm.io/v1alpha1/App/org-giantswarm/test-chart-operator-extensions)
  + one map entry added:
    release.giantswarm.io/version: 27.0.0

/spec/version  (application.giantswarm.io/v1alpha1/App/org-giantswarm/test-chart-operator-extensions)
  ± value change
    - 1.1.2
    + N/A

/metadata/annotations  (application.giantswarm.io/v1alpha1/App/org-giantswarm/test-cilium-servicemonitors)
  - one map entry removed:
    # app-operator will make sure that the app on which it depends is installed before
    app-operator.giantswarm.io/depends-on: test-prometheus-operator-crd
    
  

/metadata/labels  (application.giantswarm.io/v1alpha1/App/org-giantswarm/test-cilium-servicemonitors)
  + one map entry added:
    release.giantswarm.io/version: 27.0.0

/spec/version  (application.giantswarm.io/v1alpha1/App/org-giantswarm/test-cilium-servicemonitors)
  ± value change
    - 0.1.2
    + N/A

/metadata/annotations  (application.giantswarm.io/v1alpha1/App/org-giantswarm/test-etcd-k8s-res-count-exporter)
  - one map entry removed:
    # app-operator will make sure that the app on which it depends is installed before
    app-operator.giantswarm.io/depends-on: test-kyverno-crds
    
  

/metadata/labels  (application.giantswarm.io/v1alpha1/App/org-giantswarm/test-etcd-k8s-res-count-exporter)
  + one map entry added:
    release.giantswarm.io/version: 27.0.0

/spec/version  (application.giantswarm.io/v1alpha1/App/org-giantswarm/test-etcd-k8s-res-count-exporter)
  ± value change
    - 1.10.0
    + N/A

/metadata/annotations  (application.giantswarm.io/v1alpha1/App/org-giantswarm/test-k8s-dns-node-cache)
  - one map entry removed:
    # app-operator will make sure that the app on which it depends is installed before
    app-operator.giantswarm.io/depends-on: test-kyverno-crds
    
  

/metadata/labels  (application.giantswarm.io/v1alpha1/App/org-giantswarm/test-k8s-dns-node-cache)
  + one map entry added:
    release.giantswarm.io/version: 27.0.0

/spec/version  (application.giantswarm.io/v1alpha1/App/org-giantswarm/test-k8s-dns-node-cache)
  ± value change
    - 2.8.1
    + N/A

/metadata/annotations  (application.giantswarm.io/v1alpha1/App/org-giantswarm/test-metrics-server)
  - one map entry removed:
    # app-operator will make sure that the app on which it depends is installed before
    app-operator.giantswarm.io/depends-on: test-kyverno-crds
    
  

/metadata/labels  (application.giantswarm.io/v1alpha1/App/org-giantswarm/test-metrics-server)
  + one map entry added:
    release.giantswarm.io/version: 27.0.0

/spec/version  (application.giantswarm.io/v1alpha1/App/org-giantswarm/test-metrics-server)
  ± value change
    - 2.4.2
    + N/A

/metadata/annotations  (application.giantswarm.io/v1alpha1/App/org-giantswarm/test-net-exporter)
  - one map entry removed:
    # app-operator will make sure that the app on which it depends is installed before
    app-operator.giantswarm.io/depends-on: test-prometheus-operator-crd
    
  

/metadata/labels  (application.giantswarm.io/v1alpha1/App/org-giantswarm/test-net-exporter)
  + one map entry added:
    release.giantswarm.io/version: 27.0.0

/spec/version  (application.giantswarm.io/v1alpha1/App/org-giantswarm/test-net-exporter)
  ± value change
    - 1.21.0
    + N/A

/metadata/annotations  (application.giantswarm.io/v1alpha1/App/org-giantswarm/test-node-exporter)
  - one map entry removed:
    # app-operator will make sure that the app on which it depends is installed before
    app-operator.giantswarm.io/depends-on: test-kyverno-crds
    
  

/metadata/labels  (application.giantswarm.io/v1alpha1/App/org-giantswarm/test-node-exporter)
  + one map entry added:
    release.giantswarm.io/version: 27.0.0

/spec/version  (application.giantswarm.io/v1alpha1/App/org-giantswarm/test-node-exporter)
  ± value change
    - 1.19.0
    + N/A

/metadata/annotations  (application.giantswarm.io/v1alpha1/App/org-giantswarm/test-observability-bundle)
  - one map entry removed:
    # app-operator will make sure that the app on which it depends is installed before
    app-operator.giantswarm.io/depends-on: test-coredns
    
  

/metadata/labels  (application.giantswarm.io/v1alpha1/App/org-giantswarm/test-observability-bundle)
  + one map entry added:
    release.giantswarm.io/version: 27.0.0

/spec/version  (application.giantswarm.io/v1alpha1/App/org-giantswarm/test-observability-bundle)
  ± value change
    - 1.5.3
    + N/A

/metadata/annotations  (application.giantswarm.io/v1alpha1/App/org-giantswarm/test-observability-policies)
  - one map entry removed:
    # app-operator will make sure that the app on which it depends is installed before
    app-operator.giantswarm.io/depends-on: test-kyverno-crds
    
  

/metadata/labels  (application.giantswarm.io/v1alpha1/App/org-giantswarm/test-observability-policies)
  + one map entry added:
    release.giantswarm.io/version: 27.0.0

/spec/version  (application.giantswarm.io/v1alpha1/App/org-giantswarm/test-observability-policies)
  ± value change
    - 0.0.1
    + N/A

/metadata/annotations  (application.giantswarm.io/v1alpha1/App/org-giantswarm/test-security-bundle)
  - one map entry removed:
    # app-operator will make sure that the app on which it depends is installed before
    app-operator.giantswarm.io/depends-on: test-prometheus-operator-crd
    
  

/metadata/labels  (application.giantswarm.io/v1alpha1/App/org-giantswarm/test-security-bundle)
  + one map entry added:
    release.giantswarm.io/version: 27.0.0

/spec/catalog  (application.giantswarm.io/v1alpha1/App/org-giantswarm/test-security-bundle)
  ± value change
    - giantswarm
    + default

/spec/version  (application.giantswarm.io/v1alpha1/App/org-giantswarm/test-security-bundle)
  ± value change
    - 1.8.1
    + N/A

/metadata/labels  (application.giantswarm.io/v1alpha1/App/org-giantswarm/test-teleport-kube-agent)
  + one map entry added:
    release.giantswarm.io/version: 27.0.0

/spec/version  (application.giantswarm.io/v1alpha1/App/org-giantswarm/test-teleport-kube-agent)
  ± value change
    - 0.9.2
    + N/A

/metadata/annotations  (application.giantswarm.io/v1alpha1/App/org-giantswarm/test-vertical-pod-autoscaler)
  - one map entry removed:
    # app-operator will make sure that the app on which it depends is installed before
    app-operator.giantswarm.io/depends-on: test-prometheus-operator-crd
    
  

/metadata/labels  (application.giantswarm.io/v1alpha1/App/org-giantswarm/test-vertical-pod-autoscaler)
  + one map entry added:
    release.giantswarm.io/version: 27.0.0

/spec/version  (application.giantswarm.io/v1alpha1/App/org-giantswarm/test-vertical-pod-autoscaler)
  ± value change
    - 5.2.4
    + N/A

/metadata/labels  (cluster.x-k8s.io/v1beta1/Cluster/org-giantswarm/test)
  + one map entry added:
    release.giantswarm.io/version: 27.0.0

/metadata/labels  (helm.toolkit.fluxcd.io/v2beta1/HelmRelease/org-giantswarm/test-cilium)
  + one map entry added:
    release.giantswarm.io/version: 27.0.0

/spec/chart/spec/version  (helm.toolkit.fluxcd.io/v2beta1/HelmRelease/org-giantswarm/test-cilium)
  ± value change
    - 0.26.0
    + N/A

/metadata/labels  (helm.toolkit.fluxcd.io/v2beta1/HelmRelease/org-giantswarm/test-coredns)
  + one map entry added:
    release.giantswarm.io/version: 27.0.0

/spec  (helm.toolkit.fluxcd.io/v2beta1/HelmRelease/org-giantswarm/test-coredns)
  - one map entry removed:
    dependsOn:
    - name: test-cilium
      namespace: org-giantswarm

/spec/chart/spec/version  (helm.toolkit.fluxcd.io/v2beta1/HelmRelease/org-giantswarm/test-coredns)
  ± value change
    - 1.21.0
    + N/A

/metadata/labels  (helm.toolkit.fluxcd.io/v2beta1/HelmRelease/org-giantswarm/test-network-policies)
  + one map entry added:
    release.giantswarm.io/version: 27.0.0

/spec  (helm.toolkit.fluxcd.io/v2beta1/HelmRelease/org-giantswarm/test-network-policies)
  - one map entry removed:
    dependsOn:
    - name: test-cilium
      namespace: org-giantswarm

/spec/chart/spec/version  (helm.toolkit.fluxcd.io/v2beta1/HelmRelease/org-giantswarm/test-network-policies)
  ± value change
    - 0.1.1
    + N/A

/spec/chart/spec/sourceRef/name  (helm.toolkit.fluxcd.io/v2beta1/HelmRelease/org-giantswarm/test-network-policies)
  ± value change
    - test-cluster
    + test-default

/metadata/labels  (helm.toolkit.fluxcd.io/v2beta1/HelmRelease/org-giantswarm/test-vertical-pod-autoscaler-crd)
  + one map entry added:
    release.giantswarm.io/version: 27.0.0

/spec/chart/spec/version  (helm.toolkit.fluxcd.io/v2beta1/HelmRelease/org-giantswarm/test-vertical-pod-autoscaler-crd)
  ± value change
    - 3.1.0
    + N/A

/metadata/labels  (helm.toolkit.fluxcd.io/v2beta1/HelmRelease/org-giantswarm/release-name-cloud-provider-vsphere)
  + one map entry added:
    release.giantswarm.io/version: 27.0.0

/spec/chart/spec/version  (helm.toolkit.fluxcd.io/v2beta1/HelmRelease/org-giantswarm/release-name-cloud-provider-vsphere)
  ± value change
    - 1.11.0
    + N/A

/metadata/labels  (source.toolkit.fluxcd.io/v1beta2/HelmRepository/org-giantswarm/test-default)
  + one map entry added:
    release.giantswarm.io/version: 27.0.0

/metadata/labels  (source.toolkit.fluxcd.io/v1beta2/HelmRepository/org-giantswarm/test-default-test)
  + one map entry added:
    release.giantswarm.io/version: 27.0.0

/metadata/labels  (source.toolkit.fluxcd.io/v1beta2/HelmRepository/org-giantswarm/test-cluster)
  + one map entry added:
    release.giantswarm.io/version: 27.0.0

/metadata/labels  (source.toolkit.fluxcd.io/v1beta2/HelmRepository/org-giantswarm/test-cluster-test)
  + one map entry added:
    release.giantswarm.io/version: 27.0.0

/metadata/labels  (bootstrap.cluster.x-k8s.io/v1beta1/KubeadmConfigTemplate/org-giantswarm/test-worker-85fb5)
  + one map entry added:
    release.giantswarm.io/version: 27.0.0

/metadata/labels  (controlplane.cluster.x-k8s.io/v1beta1/KubeadmControlPlane/org-giantswarm/test)
  + one map entry added:
    release.giantswarm.io/version: 27.0.0

/spec/machineTemplate/metadata/labels  (controlplane.cluster.x-k8s.io/v1beta1/KubeadmControlPlane/org-giantswarm/test)
  + one map entry added:
    release.giantswarm.io/version: 27.0.0

/spec/version  (controlplane.cluster.x-k8s.io/v1beta1/KubeadmControlPlane/org-giantswarm/test)
  ± value change
    - v1.27.14
    + vN/A

/metadata/labels  (cluster.x-k8s.io/v1beta1/MachineDeployment/org-giantswarm/test-worker)
  + one map entry added:
    release.giantswarm.io/version: 27.0.0

/spec/template/metadata/labels  (cluster.x-k8s.io/v1beta1/MachineDeployment/org-giantswarm/test-worker)
  + one map entry added:
    release.giantswarm.io/version: 27.0.0

/metadata/labels  (cluster.x-k8s.io/v1beta1/MachineHealthCheck/org-giantswarm/test-control-plane)
  + one map entry added:
    release.giantswarm.io/version: 27.0.0

/metadata/labels  (cluster.x-k8s.io/v1beta1/MachineHealthCheck/org-giantswarm/test-worker)
  + one map entry added:
    release.giantswarm.io/version: 27.0.0

/metadata/labels  (infrastructure.cluster.x-k8s.io/v1beta1/VSphereCluster/org-giantswarm/release-name)
  + one map entry added:
    release.giantswarm.io/version: 27.0.0

/metadata/labels  (infrastructure.cluster.x-k8s.io/v1beta1/VSphereMachineTemplate/org-giantswarm/release-name-control-plane-37795751)
  + one map entry added:
    release.giantswarm.io/version: 27.0.0

/metadata/labels  (infrastructure.cluster.x-k8s.io/v1beta1/VSphereMachineTemplate/org-giantswarm/release-name-worker-84ff272a)
  + one map entry added:
    release.giantswarm.io/version: 27.0.0

/metadata/labels  (v1/ServiceAccount/org-giantswarm/test-helmreleases-cleanup)
  + one map entry added:
    release.giantswarm.io/version: 27.0.0

/metadata/labels  (rbac.authorization.k8s.io/v1/Role/org-giantswarm/test-helmreleases-cleanup)
  + one map entry added:
    release.giantswarm.io/version: 27.0.0

/metadata/labels  (rbac.authorization.k8s.io/v1/RoleBinding/org-giantswarm/test-helmreleases-cleanup)
  + one map entry added:
    release.giantswarm.io/version: 27.0.0

/metadata/labels  (batch/v1/Job/org-giantswarm/test-helmreleases-cleanup)
  + one map entry added:
    release.giantswarm.io/version: 27.0.0

/spec/template/metadata/labels  (batch/v1/Job/org-giantswarm/test-helmreleases-cleanup)
  + one map entry added:
    release.giantswarm.io/version: 27.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@njuettner